On Wed, Aug 06, 2025 at 11:57:42AM -0400, Mike Snitzer wrote:
> On Wed, Aug 06, 2025 at 09:18:51AM -0400, Chuck Lever wrote:
>
> > Before reposting, please do run checkpatch.pl on the series.
>
> Will do, will also ensure bisect safe and that sparse is happy.
FYI, I'm preparing my next patchset and sparse is happy with it, but I
wanted to share these warnings seen with nfsd-testing through commit
ae83299cc048e ("NFSD: Fix last write offset handling in
layoutcommit"):
fs/nfsd/nfs4state.c: note: in included file (through include/linux/wait.h, include/linux/wait_bit.h, include/linux/fs.h):
./include/linux/list.h:229:25: warning: context imbalance in 'put_clnt_odstate' - unexpected unlock
fs/nfsd/nfs4state.c:1188:9: warning: context imbalance in 'nfs4_put_stid' - unexpected unlock
I haven't looked at them closer. Could be you're well aware of them?
Mike
ps. but full disclosure, my baseline kernel is 6.12.24, I haven't
tried sparse against the nfsd-testing branch itself (which is based on
your nfsd-6.17); but my 6.12.24 kernel does have all NFS/NFSD/SUNRPC
changes through nfsd-6.17 + nfsd-testing commit ae83299cc048e).
