Hi Chuck, Dan, On Wed, Jul 16, 2025 at 04:31:49PM -0400, Chuck Lever wrote: > On 7/16/25 3:40 PM, Dan Carpenter wrote: > > #4: Change xdr_stream_decode_opaque_fixed() to return zero on success. > > This is the best fix. > > Since the XDR field is fixed in size, the caller already knows how many > bytes were decoded, on success. Thus, xdr_stream_decode_opaque_fixed() > doesn't need to return that value. And, xdr_stream_decode_u32 and _u64 > both return zero on success. > > Since there is only one other caller, modifying the set of return values > of xdr_stream_decode_opaque_fixed() seems sensible to me. I like this solution too, will send patches to fix. -- Sergey Bashirov
