Re: [RFC PATCH 5/6] nfs/localio: refactor iocb initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 10, 2025 at 12:23:35AM -0700, Christoph Hellwig wrote:
> > +	// FIXME: would do well to allocate memory based on NUMA node.
> > +	iocb->bvec = kmalloc_array(hdr->page_array.npages,
> > +				   sizeof(struct bio_vec), flags);
> 
> I don't think that's a "FIXME".  Either do it or leave it, but given
> that memory is allocated on the local node by default I can't see why
> that would be useful here for a short lived allocation. 

Yeah, meant to remove that FIXME.. will do for v3.




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux