On Fri, 2025-07-04 at 17:26 +1000, NeilBrown wrote: > On Fri, 04 Jul 2025, NeilBrown wrote: > > > > Otherwise it makes sense for exploring how to optimise IO. > > > > Reviewed-by: NeilBrown <neil@xxxxxxxxxx> > > Actually - I take that back. generic_fadvise() is the wrong interface. > It is for filesystems to use if the don't have any special requirements, > and for vfs_fadvise() to use if the file system hasn't give a function > to use. > > nfsd should be calling vfs_fadvise(). Good catch. I'll fix that up in the next version. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx>