[RFC PATCH 0/2] Relocate fh_getattr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Chuck Lever <chuck.lever@xxxxxxxxxx>

Tucked away in Mike's LOCALIO branch is a patch that, among other
changes, moves fh_getattr() to fs/nfsd/vfs.c. My feeling is that
either:

 - fh_getattr() remains as part of the NFSD FH API, thus it belongs
   in fs/nfsd/nfsfh.c; or

 - if it is to be relocated to fs/nfsd/vfs.c, then it should adopt
   the naming convention used for the public functions in that
   source file.

This patch series tries on the first approach, for size.

It's a nit, I know.

Chuck Lever (2):
  NFSD: Relocate the fh_want_write() and fh_drop_write() helpers
  NFSD: Move the fh_getattr() helper

 fs/nfsd/nfsfh.c | 23 +++++++++++++++++++++++
 fs/nfsd/nfsfh.h | 38 ++++++++++++++++++++++++++++++++++++++
 fs/nfsd/vfs.h   | 33 ---------------------------------
 3 files changed, 61 insertions(+), 33 deletions(-)

-- 
2.50.0





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux