On Fri, Jun 20, 2025 at 08:31:54AM -0400, Chuck Lever wrote: > + fsid[0] = new_encode_dev(MKDEV(ntohl((__force __be32)fsid[0]), > + ntohl((__force __be32)fsid[1]))); Maybe avoid the overly long line by reducing the somewhat pointlessly large indentation? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>