Re: [RFC PATCH 0/2] Remove union from struct knfsd_fh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-06-20 at 08:31 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@xxxxxxxxxx>
> 
> This is a low-risk way to simplify the knfsd_fh struct, based on
> Christoph's suggestion of using array indices rather than u8
> fields.
> 
> Compile-tested only.
> 
> Chuck Lever (2):
>   NFSD: Access a knfsd_fh's fsid by pointer
>   NFSD: Simplify struct knfsd_fh
> 
>  fs/nfsd/nfs4layouts.c |  4 ++--
>  fs/nfsd/nfsfh.c       | 16 +++++++++-------
>  fs/nfsd/nfsfh.h       | 26 +++++++++++++++-----------
>  3 files changed, 26 insertions(+), 20 deletions(-)


This all looks pretty sane to me. Overall, just a simpler way to define
this struct.

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux