On 19 Jun 2025, at 9:05, kernel test robot wrote: > Hi Benjamin, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on trondmy-nfs/linux-next] > [also build test WARNING on linus/master v6.16-rc2 next-20250618] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/NFSv4-pNFS-Fix-a-race-to-wake-on-NFS_LAYOUT_DRAIN/20250619-023749 > base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next > patch link: https://lore.kernel.org/r/43be0de9ff48ea68dec20d07cb235e164e634588.1750271744.git.bcodding%40redhat.com > patch subject: [PATCH] NFSv4/pNFS: Fix a race to wake on NFS_LAYOUT_DRAIN > config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250619/202506192044.sMgMZpkZ-lkp@xxxxxxxxx/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506192044.sMgMZpkZ-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202506192044.sMgMZpkZ-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > fs/nfs/pnfs.c: In function 'nfs_layoutget_end': >>> fs/nfs/pnfs.c:2061:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] > 2061 | if (atomic_dec_and_test(&lo->plh_outstanding) && > | ^~ > fs/nfs/pnfs.c:2064:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' > 2064 | wake_up_bit(&lo->plh_flags, NFS_LAYOUT_DRAIN); > | ^~~~~~~~~~~ > Oh what shame, thanks robot. v2 incoming. Ben
