On Fri, Jun 13, 2025 at 04:08:46PM -0400, Chuck Lever wrote: > + init_sync_kiocb(&kiocb, file); > + kiocb.ki_pos = offset; > + kiocb.ki_flags = 0; ki_flags is already cleared by init_sync_kiocb, so the line doing that can be dropped. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>