On 2025/5/28 08:25, NeilBrown wrote:
On Tue, 27 May 2025, Su Hui wrote:
kstrtoint() is better because simple_strtoul() ignores overflow and the
type of 'fsidtype' is 'int' rather than 'unsigned long'.
Thanks for the patch.
Reviewed-by: NeilBrown <neil@xxxxxxxxxx>
The valid values for fsidtype are actually 0-7 so it might be nice to
change the type to u8 everywhere and make this kstrtou8() but that isn't
really needed and shouldn't stop this patch landing.
Thanks for your suggestion.
I can try this next week in a new patch because this has been merged
into nfsd-testing and I need some time to view code.
Su Hui
