On 27 May 2025, at 17:26, Anna Schumaker wrote: > Hi Ben, > > On 5/16/25 11:31 AM, Benjamin Coddington wrote: >> On 16 May 2025, at 11:05, Jeff Layton wrote: >> >>> On Thu, 2025-05-15 at 10:40 -0400, Benjamin Coddington wrote: >>>> From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> >>>> >>>> We need to be able to track more than 32 attributes per inode. >>>> >>>> Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> >>>> Signed-off-by: Lance Shelton <lance.shelton@xxxxxxxxxxxxxxx> >>>> Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> >>>> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx> >>>> --- >>>> fs/nfs/inode.c | 5 ++-- >>>> include/linux/nfs_fs_sb.h | 2 +- >>>> include/linux/nfs_xdr.h | 54 +++++++++++++++++++-------------------- >>>> 3 files changed, 31 insertions(+), 30 deletions(-) >>>> >>>> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c >>>> index 1aa67fca69b2..d4e449fa076e 100644 >>>> --- a/fs/nfs/inode.c >>>> +++ b/fs/nfs/inode.c >>>> @@ -2164,10 +2164,11 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr) >>>> bool attr_changed = false; >>>> bool have_delegation; >>>> >>>> - dfprintk(VFS, "NFS: %s(%s/%lu fh_crc=0x%08x ct=%d info=0x%x)\n", >>>> + dfprintk(VFS, "NFS: %s(%s/%lu fh_crc=0x%08x ct=%d info=0x%lx)\n", >>>> __func__, inode->i_sb->s_id, inode->i_ino, >>>> nfs_display_fhandle_hash(NFS_FH(inode)), >>>> - atomic_read(&inode->i_count), fattr->valid); >>>> + atomic_read(&inode->i_count), >>>> + (unsigned long)fattr->valid); >>> >>> Why the cast? You could just set the format to %llx and pass fattr- >>>> valid as-is? >> >> Yes of course, the cast will be removed. > > I'm not seeing any objections to adding btime. I was wondering if you're planning > a v2 of these patches, or should I fix up the casting in my tree? I'll send a v2, hoping for more review - thanks Anna! Ben
