Hi NeilBrown, kernel test robot noticed the following build warnings: [auto build test WARNING on brauner-vfs/vfs.all] [also build test WARNING on linus/master v6.15-rc5] [cannot apply to trondmy-nfs/linux-next next-20250508] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/NeilBrown/nfs_localio-use-cmpxchg-to-install-new-nfs_file_localio/20250509-085046 base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all patch link: https://lore.kernel.org/r/20250509004852.3272120-7-neil%40brown.name patch subject: [PATCH 6/6] nfs_localio: change nfsd_file_put_local() to take a pointer to __rcu pointer config: i386-buildonly-randconfig-002-20250509 (https://download.01.org/0day-ci/archive/20250509/202505091849.42eZCL5e-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505091849.42eZCL5e-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202505091849.42eZCL5e-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/nfsd/filecache.c:382: warning: Function parameter or struct member 'pnf' not described in 'nfsd_file_put_local' >> fs/nfsd/filecache.c:382: warning: Excess function parameter 'nf' description in 'nfsd_file_put_local' vim +382 fs/nfsd/filecache.c 65294c1f2c5e72 Jeff Layton 2019-08-18 372 a61e147e6be6e7 Mike Snitzer 2024-09-05 373 /** b33f7dec3a6721 Mike Snitzer 2024-11-15 374 * nfsd_file_put_local - put nfsd_file reference and arm nfsd_net_put in caller c840b8e1f039e9 Mike Snitzer 2024-11-13 375 * @nf: nfsd_file of which to put the reference a61e147e6be6e7 Mike Snitzer 2024-09-05 376 * c840b8e1f039e9 Mike Snitzer 2024-11-13 377 * First save the associated net to return to caller, then put c840b8e1f039e9 Mike Snitzer 2024-11-13 378 * the reference of the nfsd_file. a61e147e6be6e7 Mike Snitzer 2024-09-05 379 */ c840b8e1f039e9 Mike Snitzer 2024-11-13 380 struct net * 100c0943040501 NeilBrown 2025-05-09 381 nfsd_file_put_local(struct nfsd_file __rcu **pnf) a61e147e6be6e7 Mike Snitzer 2024-09-05 @382 { 100c0943040501 NeilBrown 2025-05-09 383 struct nfsd_file *nf; 100c0943040501 NeilBrown 2025-05-09 384 struct net *net = NULL; a61e147e6be6e7 Mike Snitzer 2024-09-05 385 100c0943040501 NeilBrown 2025-05-09 386 nf = unrcu_pointer(xchg(pnf, NULL)); 100c0943040501 NeilBrown 2025-05-09 387 if (nf) { 100c0943040501 NeilBrown 2025-05-09 388 net = nf->nf_net; a61e147e6be6e7 Mike Snitzer 2024-09-05 389 nfsd_file_put(nf); 100c0943040501 NeilBrown 2025-05-09 390 } c840b8e1f039e9 Mike Snitzer 2024-11-13 391 return net; a61e147e6be6e7 Mike Snitzer 2024-09-05 392 } a61e147e6be6e7 Mike Snitzer 2024-09-05 393 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
