FWIW, we've been chasing some problems with the git regression
testsuite when attribute delegation is enabled. It would be interesting
to test this patch to see if it changes that behavior.
Can you elaborate? didn't notice that git uses the times ATTR_*_SET
variant too often.
Unfortunately, not much.
If you turn on attribute delegation, and then run the git regression
suite in a highly-threaded configuration, some of the tests fail. I've
made a couple of stabs at trying to narrow down a the reproducer, but
no luck so far.
My guess is that it's a client-side bug:
The server is fairly simple here -- if there is an outstanding
delegation, it asks the delegation holder for attributes via CB_GETATTR
and then passes those along to the client.
The client however has traditionally relied on the server to provide
updated attributes, rather than handling timestamps itself, and it
wouldn't surprise me if it just didn't get all of those places right.
It's running, not failing yet... Which test cases fail?
FWIW, I did try your patch with that test and it didn't help.