[PATCH 3/5] nfs: move the call to nfs_pageio_cond_complete in nfs_do_writepage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Calling a function before the main variable declaration is extremely
confusing, so don't do that.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
 fs/nfs/write.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 3e873c5b1041..4e1d57b63a85 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -635,10 +635,11 @@ static void nfs_write_error(struct nfs_page *req, int error)
 static int nfs_do_writepage(struct folio *folio, struct writeback_control *wbc,
 		struct nfs_pageio_descriptor *pgio)
 {
-	nfs_pageio_cond_complete(pgio, folio->index);
 	struct nfs_page *req;
 	int ret = 0;
 
+	nfs_pageio_cond_complete(pgio, folio->index);
+
 	req = nfs_lock_and_join_requests(folio);
 	if (!req)
 		goto out;
-- 
2.47.2





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux