On Fri, Apr 25, 2025 at 11:24:52AM -0400, Anna Schumaker wrote: > From: Anna Schumaker <anna.schumaker@xxxxxxxxxx> > > None of the fzero calls in this test end up writing past the end of the > file, so this flag is unnecessary and can cause the test to fail on > filesystems that don't implement FALLOC_FL_KEEP_SIZE. > > Signed-off-by: Anna Schumaker <anna.schumaker@xxxxxxxxxx> > --- This version is good to me, Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> > tests/generic/033 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/generic/033 b/tests/generic/033 > index a9a9ff5a3431..b7df56b82619 100755 > --- a/tests/generic/033 > +++ b/tests/generic/033 > @@ -37,12 +37,12 @@ $XFS_IO_PROG -f -c "pwrite 0 $bytes" $file >> $seqres.full 2>&1 > # delalloc blocks and convert the ranges to unwritten. > endoff=$((bytes - 4096)) > for i in $(seq 0 8192 $endoff); do > - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 > + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 > done > > # now zero the opposite set to remove remaining delalloc extents > for i in $(seq 4096 8192 $endoff); do > - $XFS_IO_PROG -c "fzero -k $i 4k" $file >> $seqres.full 2>&1 > + $XFS_IO_PROG -c "fzero $i 4k" $file >> $seqres.full 2>&1 > done > > _scratch_cycle_mount > -- > 2.49.0 > >
