[no subject]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



So I used the Fixes:+Cc: for such build issues or important issues to
ensure that the change is really backported.

> > > 
> > > I saw this issue using crosstools/gcc-13.3.0-nolibc and this patch fixes it.
> > 
> > So maybe the commit message can be adjusted, so it does not say only
> > "older gcc"?
> 
> I don't see the need to list all compilers, I documented the compiler
> that motivated my fix.  Fact that it applicable for
> crosstools/gcc-13.3.0-nolibc (which I don't have context for what it
> is.. but if this commit is needed for it then it is a suspect "new"
> compiler).

My impression was that the commit is fixing just the compilation with
old gcc versions. But it seems that also new are affected. That is why I
suggested to adjust it, so it would be clear that it applies for new gcc
versions too.

> > > Tested-by: Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>
> > 
> > I have tested this change and it fixed compilation for me too. So:
> > 
> > Tested-by: Pali Rohár <pali@xxxxxxxxxx>
> > 
> > > 
> > > > Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxxxxxxx>
> > > 
> > > note this doesn't match the From: address
> 
> AFAIK there is no requirement that an S-o-B tag must match the email
> header's From.
> 
> Mike




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux