Re: [PATCH] kprobe_event_gen_test : Fix error handling and resource cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This commit addresses several issues …

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94


…
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -129,6 +129,7 @@ static int __init test_gen_kprobe_cmd(void)
>  					       "gen_kprobe_test");
>  	if (IS_ERR(gen_kprobe_test)) {
>  		ret = PTR_ERR(gen_kprobe_test);
> +		gen_kprobe_test = NULL;

May the repetition be reduced for this assignment statement?


>  		goto delete;

How do you think about to use an additional label?


>  	}
…

Regards,
Markus





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux