On 18/06/2025 14.26, Petr Pavlu wrote:
> All error conditions in move_module() set the return value by updating the
> ret variable. Therefore, it is not necessary to the initialize the variable
> when declaring it.
>
> Remove the unnecessary initialization.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> Reviewed-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> ---
> kernel/module/main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 9ac994b2f354..7822b91fca6b 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2696,9 +2696,8 @@ static int find_module_sections(struct module *mod, struct load_info *info)
>
> static int move_module(struct module *mod, struct load_info *info)
> {
> - int i;
> + int i, ret;
> enum mod_mem_type t = MOD_MEM_NUM_TYPES;
> - int ret = -ENOMEM;
> bool codetag_section_found = false;
>
> for_each_mod_mem_type(type) {
Reviewed-by: Daniel Gomez <da.gomez@xxxxxxxxxxx>
