On Tue, Sep 23, 2025 at 02:13:01PM +0300, Dan Carpenter wrote: > The zl3073x_devlink_flash_prepare() function calls zl3073x_fw_free() > and the caller also calls zl3073x_devlink_flash_update() so it leads s/zl3073x_devlink_flash_update/zl3073x_fw_free/ ? > to a double free. Delete the extra free. > > Fixes: a1e891fe4ae8 ("dpll: zl3073x: Implement devlink flash callback") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Thanks Dan, Aside from the nit above, this looks good to me. Reviewed-by: Simon Horman <horms@xxxxxxxxxx> ...