[EXTERNAL] [PATCH] irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check in probe()The ioremap() function never returns error pointers, it returns NULLd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Elad Nachman <enachman@xxxxxxxxxxx>

>The ioremap() function never returns error pointers, it returns NULL
>on error.  Fix the checking to match.
>
>Fixes: 3c3d7dbab2c7 ("irqchip/mvebu-gicp: Clear pending interrupts on init")
>Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>---
> drivers/irqchip/irq-mvebu-gicp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
>index 54833717f8a7..667bde3c651f 100644
>--- a/drivers/irqchip/irq-mvebu-gicp.c
>+++ b/drivers/irqchip/irq-mvebu-gicp.c
>@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> 	}
>
> 	base = ioremap(gicp->res->start, resource_size(gicp->res));
>-	if (IS_ERR(base)) {
>+	if (!base) {
> 		dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n");
> 	} else {
> 		for (i = 0; i < 64; i++)
>-- 
>2.47.2






[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux