On Sun, Aug 24, 2025 at 12:54:41PM -0600, Brigham Campbell wrote:
> On Thu Aug 21, 2025 at 6:30 AM MDT, Dan Carpenter wrote:
> > If the mipi_dsi_dual() macro fails, the error code is stored in
> > dsi_ctx.accum_err. Propagate that error back to the caller instead
> > of returning success as the current code does.
> >
> > Fixes: a6adf47d30cc ("drm/panel: jdi-lpm102a188a: Fix bug and clean up driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Good catch, Dan! Thank you for the patch. I'll try to be mindful of this
> kind of logic error in the future. Please let me know if you have other
> suggestions.
>
Heh. This is just static checker stuff. https://github.com/error27/smatch
Humans are expected to have mechanical attention to detail at the
same level as a computer. I just try to write the commit message out to
prove that I've looked at the code as well.
regards,
dan carpenter
