Hi, On Wed, Aug 27, 2025 at 8:39 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > On Wed, 27 Aug 2025, Doug Anderson wrote: > > > > Bitwise AND was intended instead of OR. With the current code the > > > condition is always true. > > > > > > Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled") > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > --- > > > drivers/hid/i2c-hid/i2c-hid-core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx > > This seems to be missing closing bracket :) Fixed. The tools would probably have caught it, but better to be safe. ...actually, "b4" fixed it for me. :-P > > Jiri / Benjamin: if one of you can give this a quick Ack then I'll > > throw it into drm-misc-next with the patch it's fixing. > > Acked-by: Jiri Kosina <jkosina@xxxxxxxx> Pushed to drm-misc-next. [1/1] HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower() commit: 5c76c794bf29399394ebacaa5af8436b8bed0d46