>> Seems like a good idea though. But please keep the local variable >> declaration in the current place which is bit cleaner and reduces >> code churn as well. > > Though include/linux/cleanup.h suggests to "always define and assign > variables in one statement" to avoid potential interdependency problem > with lock, this is not concerned in arm_trbe_alloc_buffer(). > > So I bias to Anshuman's suggestion of declaring variables at the top > of the function, as this is the style widely used in the kernel. Does anything hinder you to follow the mentioned cleanup advice more? Regards, Markus
