From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
On Fri, 18 Jul 2025 16:22:15 -0500, Dan Carpenter wrote:
> The test for "if (!desc_data)" does not work correctly because the list
> iterator in a list_for_each_entry() loop is always non-NULL. If we don't
> exit via a break, then it points to invalid memory. Instead, use a tmp
> variable for the list iterator and only set the "desc_data" when we have
> found a match.
>
>
> [...]
Thanks for catching it. This is not obvious because in normal circumstances
we'll always find a matching descriptor and exit the loop via break so it's
hard to trigger a bug this way. Anyway, the patch is correct so applied.
[1/1] gpio: sysfs: Fix an end of loop test in gpiod_unexport()
https://git.kernel.org/brgl/linux/c/5607f5ed3c5f30f41e72ce09c8e616af0fc0d474
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
