Re: [PATCH] ring-buffer: make the const read-only 'type' static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 Jul 2025 17:08:58 +0100
Colin Ian King <colin.i.king@xxxxxxxxx> wrote:

> Don't populate the read-only 'type' on the stack at run time,
> instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 00fc38d70e86..39aa1f50274f 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -4118,7 +4118,7 @@ EXPORT_SYMBOL_GPL(ring_buffer_unlock_commit);
>  
>  static const char *show_irq_str(int bits)
>  {
> -	const char *type[] = {
> +	static const char * type[] = {

Better would be:
	static const char type[][4] = {

  David

>  		".",	// 0
>  		"s",	// 1
>  		"h",	// 2





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux