On Tue, Jun 10, 2025 at 12:28:43PM +0200, Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Tue, 10 Jun 2025 11:44:20 +0200 > > It can be known that the function “kfree” performs a null pointer check > for its input parameter. > It is therefore not needed to repeat such a check before its call. > > Thus remove a redundant pointer check. > > The source code was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > arch/mips/sgi-ip27/ip27-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c > index 288d4d17eddd..20ef663af16e 100644 > --- a/arch/mips/sgi-ip27/ip27-irq.c > +++ b/arch/mips/sgi-ip27/ip27-irq.c > @@ -165,7 +165,7 @@ static void hub_domain_free(struct irq_domain *domain, > return; > > irqd = irq_domain_get_irq_data(domain, virq); > - if (irqd && irqd->chip_data) > + if (irqd) > kfree(irqd->chip_data); > } > > -- > 2.49.0 applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
