Re: [PATCH next] mmc: loongson2: Fix error code in loongson2_mmc_resource_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan:

Ah, sorry  for my cheap fault, and thanks for your patch.

On 2025/7/16 07:00, Dan Carpenter wrote:
There is a cut and paste bug so we accidentally return the wrong
variable.  It should be "ret" instead of PTR_ERR(host->clk).

Fixes: 2115772014bd ("mmc: loongson2: Add Loongson-2K SD/SDIO controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


Reviewed-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>

---
  drivers/mmc/host/loongson2-mmc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
index ba6bb8fd5535..63d01d2cd978 100644
--- a/drivers/mmc/host/loongson2-mmc.c
+++ b/drivers/mmc/host/loongson2-mmc.c
@@ -887,7 +887,7 @@ static int loongson2_mmc_resource_request(struct platform_device *pdev,
  	if (host->clk) {
  		ret = devm_clk_rate_exclusive_get(dev, host->clk);
  		if (ret)
-			return PTR_ERR(host->clk);
+			return ret;
host->current_clk = clk_get_rate(host->clk);
  	} else {


Thanks.
Binbin





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux