Hi Colin:
Thanks for your patch.
Sergio has already submitted the relevant patch to fix this issue:
https://lore.kernel.org/all/20250707185545.46275-1-sperezglz@xxxxxxxxx/
Thank you for your attention to loongson2 mmc driver.
在 2025/7/8 21:53, Colin Ian King 写道:
From: Colin Ian King <colin.i.king@xxxxxxxxx>
Currently the u32 variable ret is being assigned the return value from
the call to regmap_read_poll_timeout and checking for a less than zero
error return and this check is always false. Fix this by making ret a
signed integer.
Fixes: d0f8e961deae ("mmc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
---
drivers/mmc/host/loongson2-mmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
index 515ccf834f0a..ba6bb8fd5535 100644
--- a/drivers/mmc/host/loongson2-mmc.c
+++ b/drivers/mmc/host/loongson2-mmc.c
@@ -485,7 +485,8 @@ static irqreturn_t loongson2_mmc_irq(int irq, void *devid)
static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
{
- u32 val, pad_delay, delay, ret;
+ u32 val, pad_delay, delay;
+ int ret;
regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);
Thanks.
Binbin
