> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Wednesday, July 2, 2025 6:25 PM
> To: Kandpal, Suraj <suraj.kandpal@xxxxxxxxx>; Maarten Lankhorst
> <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>; Thomas Zimmermann
> <tzimmermann@xxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter
> <simona@xxxxxxxx>; Nikula, Jani <jani.nikula@xxxxxxxxx>; Deak, Imre
> <imre.deak@xxxxxxxxx>; Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; Dmitry
> Baryshkov <lumag@xxxxxxxxxx>; Andy Yan <andy.yan@xxxxxxxxxxxxxx>; Dave
> Airlie <airlied@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] drm/dp: Clean up white space in
> drm_edp_backlight_probe_state()
>
> This code needs to be indented one more tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> ---
> drivers/gpu/drm/display/drm_dp_helper.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
> b/drivers/gpu/drm/display/drm_dp_helper.c
> index db7896c7edb8..1c3920297906 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -4245,14 +4245,14 @@ drm_edp_backlight_probe_state(struct
> drm_dp_aux *aux, struct drm_edp_backlight_i
> "%s: Failed to read backlight level:
> %d\n",
> aux->name, ret);
> return ret;
> - }
> + }
>
> - /*
> - * Incase luminance is set we want to send the value back in
> nits but since
> - * DP_EDP_PANEL_TARGET_LUMINANCE stores values in
> millinits we need to divide
> - * by 1000.
> - */
> - return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
> + /*
> + * Incase luminance is set we want to send the value
> back in nits but
> + * since DP_EDP_PANEL_TARGET_LUMINANCE stores
> values in millinits we
> + * need to divide by 1000.
> + */
> + return (buf[0] | buf[1] << 8 | buf[2] << 16) / 1000;
> } else {
> ret = drm_dp_dpcd_read_data(aux,
> DP_EDP_BACKLIGHT_BRIGHTNESS_MSB,
> buf, size);
> --
> 2.47.2
