On 7/1/2025 2:20 PM, Lukas Bulwahn wrote: > From: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx> > > In the Makefile, the new build option CONFIG_CAAM_QI is defined conditioned > on the existence of the CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI, which is > properly defined in the Kconfig file. So, CONFIG_CAAM_QI is just a local > alias for CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI. > > There is little benefit in the source code of having this slightly shorter > alias for this configuration, but it complicates further maintenance, as > searching for the impact of CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI > requires to grep once, and then identify the option introduced and continue > searching for that. Further, tools, such as cross referencers, and scripts > to check Kconfig definitions and their use simply do not handle this > situation. Given that this is the only incidence of such a config alias in > the whole kernel tree, just prefer to avoid this pattern of aliasing here. > > Use CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI throughout the Freescale > CAAM-Multicore platform driver backend source code. > > No functional change. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx> Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx> Thanks, Horia
