I have a pile of potential janitorial work for interested parties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Quite some time ago, I was immersed in a bunch of Linux kernel
janitorial work, and I wrote a bunch of scripts that scanned the
kernel source tree and identified obvious candidates for
simplification and cleanup. I'm going to publish all of that to my
website in the very near future, but just to clarify what I mean, let
me provide a single example to see if this is still relevant, or
whether I'm off-base.

  One of the scripts I wrote scanned the kernel tree for what I call
"badref selects", those being entries in Kconfig files that "select"ed
config entries that did not exist (probably the result of someone
deleting config entries, but not checking to see if anything selected
that entry). Such occurrences are not fatal, but they are obvious
candidates for cleanup.

  I just ran that script on the current source tree just for the
drivers/ directory, and here's the output I got:


$ find_badref_selects.sh drivers
===== DRM_DEBUG_SELFTEST
drivers/gpu/drm/i915/Kconfig.debug:53:	select DRM_DEBUG_SELFTEST
===== DRM_KMS_DMA_HELPER
drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
===== TEST_KUNIT_DEVICE_HELPERS
drivers/iio/test/Kconfig:11:	select TEST_KUNIT_DEVICE_HELPERS


This output suggests that those "selects" refer to config entries that
do not exist, and so could likely be removed as janitorial work.

  Does the above make sense? If I recursively grep for the strings,
say, "TEST_KUNIT_DEVICE_HELPERS", I see only that select statement,
and nothing else. I'm assuming that means it's superfluous. If this
makes sense, I can publish my scanning scripts and others are welcome
to use them to find stuff that can be cleaned up.

  Thoughts?

rday




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux