On 25.06.25 17:22, Dan Carpenter wrote:
The "reason" variable is uninitialized on this error path. It's supposed
to explain why the function failed.
Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
mm/memory_hotplug.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 4d864b4fb891..e954f81b55a0 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages,
node_arg.nid = node;
ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg);
ret = notifier_to_errno(ret);
- if (ret)
+ if (ret) {
+ reason = "nr_pages more than present_pages";
"node notifier failure"
With that
Acked-by: David Hildenbrand <david@xxxxxxxxxx>
(likely should be squashed because the commit it might not be stable yet)
--
Cheers,
David / dhildenb
