On Thu, 19 Jun 2025, Colin Ian King wrote:
> Don't populate the read-only array reconnect_event on the stack
> at run time, instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> drivers/hid/hid-uclogic-params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c
> index a6044996abf2..b3d56057cec9 100644
> --- a/drivers/hid/hid-uclogic-params.c
> +++ b/drivers/hid/hid-uclogic-params.c
> @@ -1341,7 +1341,7 @@ static int uclogic_params_ugee_v2_init_event_hooks(struct hid_device *hdev,
> struct uclogic_params *p)
> {
> struct uclogic_raw_event_hook *event_hook;
> - __u8 reconnect_event[] = {
> + static const __u8 reconnect_event[] = {
> /* Event received on wireless tablet reconnection */
> 0x02, 0xF8, 0x02, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
Good catch. Applied, thanks.
--
Jiri Kosina
SUSE Labs
