On 6/11/25 15:09, Dan Carpenter wrote:
> If reset_control_acquire() fails, then we can't return directly.
> We need to do a little clean up first.
>
> Fixes: cf2c3eceb757 ("spi: stm32-ospi: Make usage of reset_control_acquire/release() API")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/spi/spi-stm32-ospi.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c
> index db6b1cfc970f..4ab7e86f4bd5 100644
> --- a/drivers/spi/spi-stm32-ospi.c
> +++ b/drivers/spi/spi-stm32-ospi.c
> @@ -937,8 +937,10 @@ static int stm32_ospi_probe(struct platform_device *pdev)
> goto err_pm_enable;
>
> ret = reset_control_acquire(ospi->rstc);
> - if (ret)
> - return dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
> + if (ret) {
> + dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
> + goto err_pm_resume;
> + }
>
> reset_control_assert(ospi->rstc);
> udelay(2);
Hi Dan
Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
Thanks
Patrice
