Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-06-06 at 12:04 +0300, Dan Carpenter wrote:
> Return -ENOMEM instead of success if kcalloc() fails.
> 
> Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add
> interface to get Linux die ID")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>


> ---
>  drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c
> b/drivers/platform/x86/intel/tpmi_power_domains.c
> index 0c5c88eb7baf..9d8247bb9cfa 100644
> --- a/drivers/platform/x86/intel/tpmi_power_domains.c
> +++ b/drivers/platform/x86/intel/tpmi_power_domains.c
> @@ -228,8 +228,10 @@ static int __init tpmi_init(void)
>  
>  	domain_die_map = kcalloc(size_mul(topology_max_packages(),
> MAX_POWER_DOMAINS),
>  				 sizeof(*domain_die_map),
> GFP_KERNEL);
> -	if (!domain_die_map)
> +	if (!domain_die_map) {
> +		ret = -ENOMEM;
>  		goto free_domain_mask;
> +	}
>  
>  	ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
>  				"platform/x86/tpmi_power_domains:onl
> ine",





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux