On Tue, May 27, 2025 at 7:54 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The error code is not set correctly on if kasprintf() fails. On the
> first iteration it would return -EINVAL and subsequent iterations
> would return success. Set it to -ENOMEM.
>
> In real life, this allocation will not fail and if it did the system
> will not boot so this change is mostly to silence static checker warnings
> more than anything else.
>
> Fixes: 04f53540f791 ("ACPI: MRRM: Add /sys files to describe memory ranges")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/acpi/acpi_mrrm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_mrrm.c b/drivers/acpi/acpi_mrrm.c
> index 2f22f013959a..70088cdfde13 100644
> --- a/drivers/acpi/acpi_mrrm.c
> +++ b/drivers/acpi/acpi_mrrm.c
> @@ -156,8 +156,10 @@ static __init int add_boot_memory_ranges(void)
>
> for (int i = 0; i < mrrm_mem_entry_num; i++) {
> name = kasprintf(GFP_KERNEL, "range%d", i);
> - if (!name)
> + if (!name) {
> + ret = -ENOMEM;
> break;
> + }
>
> kobj = kobject_create_and_add(name, pkobj);
>
> --
Applied, thanks!
