[bug report] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello David Howells,

Commit 5800b1cf3fd8 ("rxrpc: Allow CHALLENGEs to the passed to the
app for a RESPONSE") from Apr 11, 2025 (linux-next), leads to the
following Smatch static checker warning:

	net/rxrpc/insecure.c:48 none_validate_challenge()
	warn: '(-71)' is not bool

net/rxrpc/insecure.c
    45 static bool none_validate_challenge(struct rxrpc_connection *conn,
    46                                     struct sk_buff *skb)
    47 {
--> 48         return rxrpc_abort_conn(conn, skb, RX_PROTOCOL_ERROR, -EPROTO,
    49                                 rxrpc_eproto_rxnull_challenge);

rxrpc_abort_conn() always returns -EPROTO.  Could we change this to
something like?

	rxrpc_abort_conn(conn, skb, RX_PROTOCOL_ERROR, -EPROTO,
			 rxrpc_eproto_rxnull_challenge);
	return true;

    50 }

regards,
dan carpenter