On Wed, May 21, 2025 at 4:11 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Wed, May 21, 2025, at 12:02, Alexander Potapenko wrote:
> > On Tue, May 20, 2025 at 4:57 PM 'Dmitry Vyukov' via kasan-dev
> > <kasan-dev@xxxxxxxxxxxxxxxx> wrote:
> >>
> >> On Thu, 8 May 2025 at 18:44, Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> >> >
> >> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote:
> >> > > From: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx>
> >> > >
> >> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes the
> >> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the
> >> > > compiler option '-fsanitize-coverage=trace-pc' by now.
> >> > >
> >> > > The commit however misses the important use of this config option in
> >> > > Makefile.kcov to add '-fsanitize-coverage=trace-pc' to CFLAGS_KCOV.
> >> > > Include the compiler option '-fsanitize-coverage=trace-pc' unconditionally
> >> > > to CFLAGS_KCOV, as all compilers provide that option now.
> >> > >
> >> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin")
> >> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxxx>
> >> >
> >> > Good catch.
> >> >
> >> > Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> >>
> >> Reviewed-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> >>
> >> Thanks for fixing this!
> >
> > @akpm, could you please take this patch at your convenience?
>
> I have applied it on the asm-generic tree now, as this contains
> the original broken commit. Sorry for missing it earlier.
Thanks!
