Re: [PATCH v2] i2c: Fix grammatical errors in i2c_msg documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sun, 11 May 2025, Viswanath wrote:

> Fix the following grammatical errors in i2c_msg documentation:
> 1. Makes only sense in → Makes sense only in
> 2. may have changed those standard protocol behaviors →
>    may alter the standard protocol behavior
>
> Signed-off-by: Viswanath <viswanathiyyappan@xxxxxxxxx>
> ---
>  include/uapi/linux/i2c.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/i2c.h b/include/uapi/linux/i2c.h
> index 92326ebde350..aa751389de07 100644
> --- a/include/uapi/linux/i2c.h
> +++ b/include/uapi/linux/i2c.h
> @@ -24,7 +24,7 @@
>   *   %I2C_M_RD: read data (from slave to master). Guaranteed to be 0x0001!
>   *
>   *   Optional:
> - *   %I2C_M_DMA_SAFE: the buffer of this message is DMA safe. Makes only sense
> + *   %I2C_M_DMA_SAFE: the buffer of this message is DMA safe. Makes sense only
>   *     in kernelspace, because userspace buffers are copied anyway
>   *
>   *   Only if I2C_FUNC_10BIT_ADDR is set:
> @@ -66,7 +66,7 @@
>   * @i2c_msg transaction segment, beginning with a (repeated) START.
>   *
>   * Alternatively, when the adapter supports %I2C_FUNC_PROTOCOL_MANGLING then
> - * passing certain @flags may have changed those standard protocol behaviors.
> + * passing certain @flags may alter the standard protocol behavior.

The meaning seems different.

In any case, changes should go to the maintainer, and not only to this
list.

julia

>   * Those flags are only for use with broken/nonconforming slaves, and with
>   * adapters which are known to support the specific mangling options they need.
>   */
> --
> 2.49.0
>
>
>

[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux