> -----Original Message----- > From: Colin Ian King <colin.i.king@xxxxxxxxx> > Sent: Wednesday, May 7, 2025 3:19 PM > To: Bernard Metzler <BMT@xxxxxxxxxxxxxx>; Jason Gunthorpe <jgg@xxxxxxxx>; > Leon Romanovsky <leon@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [EXTERNAL] [PATCH][next] RDMA/siw: replace redundant ternary > operator with just rv > > The use of the ternary operator on rv is redundant, rv is > either the initialized value of 0 or a negative error return > code, so it can never be greater than zero, and hence the > zero assignment in ternary operator is redundant. Just return > rv instead. > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > --- > drivers/infiniband/sw/siw/siw_verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/siw/siw_verbs.c > b/drivers/infiniband/sw/siw/siw_verbs.c > index 7ce0035c54fa..2b2a7b8e93b0 100644 > --- a/drivers/infiniband/sw/siw/siw_verbs.c > +++ b/drivers/infiniband/sw/siw/siw_verbs.c > @@ -1102,7 +1102,7 @@ int siw_post_receive(struct ib_qp *base_qp, const > struct ib_recv_wr *wr, > siw_dbg_qp(qp, "error %d\n", rv); > *bad_wr = wr; > } > - return rv > 0 ? 0 : rv; > + return rv; > } > > int siw_destroy_cq(struct ib_cq *base_cq, struct ib_udata *udata) > -- > 2.49.0 Thanks Colin, makes sense. Acked-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
