These two > comparisons should be >= to prevent reading beyond the end of the array. Fixes: 2dd40523b7e2 ("platform/x86: Introduce dasharo-acpi platform driver") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/platform/x86/dasharo-acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dasharo-acpi.c b/drivers/platform/x86/dasharo-acpi.c index f10f52e44641..f0c5136af29d 100644 --- a/drivers/platform/x86/dasharo-acpi.c +++ b/drivers/platform/x86/dasharo-acpi.c @@ -101,10 +101,10 @@ static int dasharo_read_channel(struct dasharo_data *data, char *method, enum da acpi_status status; u64 val; - if (feat > ARRAY_SIZE(data->capabilities)) + if (feat >= ARRAY_SIZE(data->capabilities)) return -EINVAL; - if (channel > data->caps_found[feat]) + if (channel >= data->caps_found[feat]) return -EINVAL; obj[0].type = ACPI_TYPE_INTEGER; -- 2.47.2