On Wed, Apr 30, 2025 at 09:34:35AM +0100, Colin Ian King wrote:
> The kmalloc failure message is just noise. Remove it and
> replace -EFAULT with -ENOMEM as standard for out of memory
> allocation error returns.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> ---
> V1: remove trailing space after \n
> V2: remove entire message, originally just removed a trailing space
> V3: replace -EFAULT with -ENOMEM
> V4: send correct fix for V3, actually return -ENOMEM
> ---
>
> drivers/char/tpm/eventlog/tpm1.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
> index 12ee42a31c71..e7913b2853d5 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -257,11 +257,8 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
> (unsigned char *)(v + sizeof(struct tcpa_event));
>
> eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);
> - if (!eventname) {
> - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ",
> - __func__);
> - return -EFAULT;
> - }
> + if (!eventname)
> + return -ENOMEM;
>
> /* 1st: PCR */
> seq_printf(m, "%2d ", do_endian_conversion(event->pcr_index));
> --
> 2.49.0
>
Ya, I think this make sense.
Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
BR, Jarkko
