NAK, sent the wrong patch! Doh. On 30/04/2025 09:00, Colin Ian King wrote:
The kmalloc failure message is just noise. Remove it and replace -EFAULT with -ENOMEM as standard for out of memory allocation error returns. Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> --- V1: remove trailing space after \n V2: remove entire message, originally just removed a trailing space V3: replace -EFAULT with -ENOMEM --- drivers/char/tpm/eventlog/tpm1.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c index 12ee42a31c71..773e9e537991 100644 --- a/drivers/char/tpm/eventlog/tpm1.c +++ b/drivers/char/tpm/eventlog/tpm1.c @@ -257,11 +257,8 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v) (unsigned char *)(v + sizeof(struct tcpa_event));eventname = kmalloc(MAX_TEXT_EVENT, GFP_KERNEL);- if (!eventname) { - printk(KERN_ERR "%s: ERROR - No Memory for event name\n ", - __func__); + if (!eventname) return -EFAULT; - }/* 1st: PCR */seq_printf(m, "%2d ", do_endian_conversion(event->pcr_index));
Attachment:
OpenPGP_0x68C287DFC6A80226.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature