On Wed, Apr 23, 2025 at 11:31:56AM +0200, Jerome Brunet wrote:
> On Wed 23 Apr 2025 at 11:17, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> > The auxiliary_device_create() function returns NULL. It doesn't return
> > error pointers. Update the checking to match.
> >
> > Fixes: eaa0d30216c1 ("driver core: auxiliary bus: add device creation helpers")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Thanks for catching this mistake Dan.
>
> The thing was initially setup to return error code. Greg asked to
> simply return NULL on error and I forgot to re-align the devm variant.
>
> So I think the fix should be to check for NULL as you did but return
> NULL too so it is aligned with non-devm variant.
>
> If you wish, I can handle a v2.
Of course, it's hard to resist an offer like that but I can send a v2.
regards,
dan carpenter
