Re: [PATCH net-next 11/15] ice: make const read-only array dflt_rules static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/12/25 1:43 AM, Tony Nguyen wrote:
> From: Colin Ian King <colin.i.king@xxxxxxxxx>
> 
> Don't populate the const read-only array dflt_rules on the stack at run
> time, instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
> Tested-by: Rinitha S <sx.rinitha@xxxxxxxxx> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> index 1d118171de37..aceec184e89b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
> @@ -1605,7 +1605,7 @@ void ice_fdir_replay_fltrs(struct ice_pf *pf)
>   */
>  int ice_fdir_create_dflt_rules(struct ice_pf *pf)
>  {
> -	const enum ice_fltr_ptype dflt_rules[] = {
> +	static const enum ice_fltr_ptype dflt_rules[] = {
>  		ICE_FLTR_PTYPE_NONF_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_UDP,
>  		ICE_FLTR_PTYPE_NONF_IPV6_TCP, ICE_FLTR_PTYPE_NONF_IPV6_UDP,
>  	};


-- 
Regards,
Usama




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux