On Wed, Mar 19, 2025 at 06:38:49PM +0100, Paolo Abeni wrote: > On 3/12/25 6:21 PM, Dan Carpenter wrote: > > This NULL check is unnecessary and can be removed. It confuses > > Smatch static analysis tool because it makes Smatch think that > > xfrm_lookup_with_ifid() can return a mix of NULL pointers and errors so > > it creates a lot of false positives. Remove it. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > I have wanted to remove this NULL check for a long time. Someone > > said it could be done safely. But please, please, review this > > carefully. > > I think it's better if this patch goes first into the ipsec/xfrm tree, > so that hopefully it gets some serious testing before landing into net-next. > > @Steffen, @Herber: could you please take this in your tree? It is currently sitting in my testing branch and will be merged to the ipsec tree by the end of the week if no issues were found.
