On Tue, Aug 19, 2025 at 10:13 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Sat, Aug 16, 2025 at 04:15:18AM +0200, Jihed Chaibi wrote: > > Update the TI TWL family Device Tree binding to include additional > > subnodes for TWL4030, TWL6030, and TWL6032 devices. > > > > The simple power and PWM bindings (ti,twl4030-power, ti,twl-pwm, and > > ti,twl-pwmled) are now defined directly within this binding. > > > > Other child node definitions (audio, gpio, keypad, usb, etc.) are also > > added to the schema. These additions fix 'unevaluated properties' > > errors found during dtbs_check for boards like the omap3-beagle > > and improve the binding's overall completeness. > > > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@xxxxxxxxx> > > > > --- > > Changes in v3: > > - New patch to consolidate simple bindings (power, pwm) and add > > definitions for all child nodes to fix dtbs_check validation > > errors found in v2. > > --- > > .../devicetree/bindings/mfd/ti,twl.yaml | 191 ++++++++++++++++++ > > .../devicetree/bindings/mfd/twl4030-power.txt | 48 ----- > > .../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 -- > > .../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 -- > > 4 files changed, 191 insertions(+), 82 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mfd/twl4030-power.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt > > delete mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > index f162ab60c..b0f1cb7b5 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml > > @@ -76,6 +76,98 @@ allOf: > > properties: > > compatible: > > const: ti,twl4030-wdt > > + > > + audio: > > + type: object > > + $ref: /schemas/sound/ti,twl4030-audio.yaml# > > + unevaluatedProperties: false > > + > > + keypad: > > + type: object > > + $ref: /schemas/input/ti,twl4030-keypad.yaml# > > + unevaluatedProperties: false > > + > > + pwm: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwm > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + pwmled: > > + type: object > > + $ref: /schemas/pwm/pwm.yaml# > > + unevaluatedProperties: false > > + description: | > > + TWL4030 series: PWMA and PWMB (connected to LEDA and LEDB terminals) > > + properties: > > + compatible: > > + enum: > > + - ti,twl4030-pwmled > > + '#pwm-cells': > > + const: 2 > > + required: > > + - compatible > > + - '#pwm-cells' > > + > > + 'twl4030-usb': > > No need for quotes. > > > + type: object > > + $ref: /schemas/usb/ti,twlxxxx-usb.yaml# > > Are you sure your patchset is bsiectable? Apply this patch and test. You > will see errors and you must fix these. Even after fixing you have > strict dependencies so your cover letter must explain these (or merging > constraints)... > > I suggest listing here only compatible with additionalProperties:true > and splitting entire patchset per different maintainers. Hi Krzysztof, Thank you for the review. That additionalProperties suggestion is definitely helpful in this scenario. I will split (in v4) the patchset into smaller & independent series for each subsystem as recommended. Thanks again for your guidance. Jihed
