> -----Original Message----- > From: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > Sent: Tuesday, August 26, 2025 9:35 PM > To: Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; jikos@xxxxxxxxxx; bentiss@xxxxxxxxxx > Cc: linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] hid: intel-thc-hid: intel-quicki2c: Add WCL Device IDs > > On Tue, 2025-08-26 at 15:27 +0800, Xinpeng Sun wrote: > > Not even a single line of description? Will add a simple description in next version. Thanks, Xinpeng > > Thanks, > Srinivas > > > Signed-off-by: Xinpeng Sun <xinpeng.sun@xxxxxxxxx> > > --- > > drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 ++ > > drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c > > b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c > > index f122fde879b9..17b1f2df8f8a 100644 > > --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c > > +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c > > @@ -1019,6 +1019,8 @@ static const struct pci_device_id > > quicki2c_pci_tbl[] = { > > { PCI_DEVICE_DATA(INTEL, THC_PTL_H_DEVICE_ID_I2C_PORT2, > > &ptl_ddata) }, > > { PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_I2C_PORT1, > > &ptl_ddata) }, > > { PCI_DEVICE_DATA(INTEL, THC_PTL_U_DEVICE_ID_I2C_PORT2, > > &ptl_ddata) }, > > + { PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_I2C_PORT1, > > &ptl_ddata) }, > > + { PCI_DEVICE_DATA(INTEL, THC_WCL_DEVICE_ID_I2C_PORT2, > > &ptl_ddata) }, > > { } > > }; > > MODULE_DEVICE_TABLE(pci, quicki2c_pci_tbl); diff --git > > a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h > > b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h > > index b78c8864d39e..240492a38c24 100644 > > --- a/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h > > +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-dev.h > > @@ -13,6 +13,8 @@ > > #define > > PCI_DEVICE_ID_INTEL_THC_PTL_H_DEVICE_ID_I2C_PORT2 0xE34A > > #define > > PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_I2C_PORT1 0xE448 > > #define > > PCI_DEVICE_ID_INTEL_THC_PTL_U_DEVICE_ID_I2C_PORT2 0xE44A > > +#define > > PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_I2C_PORT1 0x4D48 > > +#define > > PCI_DEVICE_ID_INTEL_THC_WCL_DEVICE_ID_I2C_PORT2 0x4D4A > > > > /* Packet size value, the unit is 16 bytes */ > > #define MAX_PACKET_SIZE_VALUE_LNL 256