On Mon, 1 Sep 2025, Janne Grunau wrote:
> Commit 84c9d2a968c82 ("HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd
> Fn keys") added a dependency on ACPI's platform_profile. This should not
> be done for generic USB devices as this prevents using the devices on
> non ACPI devices like Apple silicon Macs and other non-ACPI arm64
> systems. An attempt to allow using platform_profile on non-ACPI systems
> was rejected in [1] and instead platform_profile was made to fail during
> init in commit dd133162c9cf ("ACPI: platform_profile: Avoid initializing
> on non-ACPI platforms").
> So remove the broken dependency and instead let's user space handle this
> keycode by sending the new KEY_PERFORMANCE. Stable backport depends on
> commit 89c5214639294 ("Input: add keycode for performance mode key").
>
> [1]: https://lore.kernel.org/linux-acpi/CAJZ5v0icRdTSToaKbdf=MdRin4NyB2MstUVaQo8VR6-n7DkVMQ@xxxxxxxxxxxxxx/
>
> Cc: regressions@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 84c9d2a968c82 ("HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys")
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> ---
> #regzbot introduced: 84c9d2a968c82
Applied, thanks.
--
Jiri Kosina
SUSE Labs
