On Wed, 23 Jul 2025, Zhang Lixu wrote: > During s2idle suspend/resume testing on some systems, occasional several > tens of seconds delays were observed in HID sensor resume handling. Trace > analysis revealed repeated "link not ready" timeout errors during > set/get_report operations, which were traced to the > hid_ishtp_cl_resume_handler() timing out while waiting for the ISHTP > resume acknowledgment. The previous timeout was set to 50ms, which proved > insufficient on affected machines. > > Empirical measurements on failing systems showed that the time from ISH > resume initiation to receiving the ISHTP resume ack could be as long as > 180ms. As a result, the 50ms timeout caused failures. > > To address this, increase the wait timeout for ISHTP resume ack from 50ms > to 300ms, providing a safer margin for slower hardware. Additionally, add > error logging when a timeout occurs to aid future debugging and issue > triage. No functional changes are made beyond the timeout adjustment and > improved error reporting. > > Signed-off-by: Zhang Lixu <lixu.zhang@xxxxxxxxx> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> Applied to hid.git#for-6.17/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs
